<html>
<head><meta charset="utf-8"><title>review requests · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html">review requests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="160557840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160557840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160557840">(Mar 12 2019 at 10:12)</a>:</h4>
<p>As an experiment, I'm inviting people to post review requests here. (And I'm going transcribe some recent ones that I saw in other streams/topics)</p>



<a name="160557951"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160557951" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160557951">(Mar 12 2019 at 10:14)</a>:</h4>
<p><em><a href="#narrow/stream/185694-t-compiler.2Fwg-meta/topic/expert.20map/near/160529332" title="#narrow/stream/185694-t-compiler.2Fwg-meta/topic/expert.20map/near/160529332">(transcribed)</a></em></p>
<blockquote>
<p>does anyone feel like an expert on <code>infer</code>?</p>
<p>specifically regarding the confidence to review <a href="https://github.com/rust-lang/rust/pull/59008" target="_blank" title="https://github.com/rust-lang/rust/pull/59008">https://github.com/rust-lang/rust/pull/59008</a></p>
</blockquote>



<a name="160558075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160558075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160558075">(Mar 12 2019 at 10:16)</a>:</h4>
<p><em><a href="#narrow/stream/185694-t-compiler.2Fwg-meta/topic/expert.20map/near/160548072" title="#narrow/stream/185694-t-compiler.2Fwg-meta/topic/expert.20map/near/160548072">(transcribed)</a></em></p>
<blockquote>
<p>Also, does anybody wants to review <a href="https://github.com/rust-lang/rust/pull/58349" target="_blank" title="https://github.com/rust-lang/rust/pull/58349">https://github.com/rust-lang/rust/pull/58349</a> (resolve: Simplify import resolution for mixed 2015/2018 edition mode)?<br>
I usually reassign anything assigned to <span class="user-mention silent" data-user-id="116083">pnkfelix</span>, but in this case I'm not sure who'd be the proper candidate.</p>
</blockquote>



<a name="160558556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160558556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160558556">(Mar 12 2019 at 10:24)</a>:</h4>
<p>(heh I transcribed the latter robotically, even after I had responded saying I would try to get around to the review today... ugh need more sleep or more coffee)</p>



<a name="160564546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160564546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160564546">(Mar 12 2019 at 12:11)</a>:</h4>
<p>No idea who to <code>r?</code> here. A review would be appreciated: <a href="https://github.com/rust-lang/rust/pull/59128" target="_blank" title="https://github.com/rust-lang/rust/pull/59128">https://github.com/rust-lang/rust/pull/59128</a> It's about emitting color codes in json diagnostics</p>



<a name="160564891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160564891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160564891">(Mar 12 2019 at 12:17)</a>:</h4>
<p>It all looks reasonable to me, but I'm not familiar with that code at all.</p>



<a name="160565182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160565182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160565182">(Mar 12 2019 at 12:23)</a>:</h4>
<p>(also, why hasn't highfive assigned someone?)</p>



<a name="160566254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160566254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160566254">(Mar 12 2019 at 12:40)</a>:</h4>
<p>because I screwed up and <code>r?</code>ed someone who doesn't have powers</p>



<a name="160801610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160801610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160801610">(Mar 14 2019 at 17:12)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> left a comment.</p>



<a name="160801652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160801652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160801652">(Mar 14 2019 at 17:13)</a>:</h4>
<p>Anyone with good insights into <code>impl Trait</code> returns and lifetimes, can you take a look at this hack and see if <em>reasonable</em>?<br>
<a href="https://github.com/rust-lang/rust/pull/58919/files" target="_blank" title="https://github.com/rust-lang/rust/pull/58919/files">https://github.com/rust-lang/rust/pull/58919/files</a></p>



<a name="160818416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160818416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160818416">(Mar 14 2019 at 20:18)</a>:</h4>
<p>it definitely seems like a hack (just from seeing how its inspecting the name to see <code>'static</code>); if <span class="user-mention" data-user-id="116009">@nikomatsakis</span> doesn't look at it by tomorrow morning, I will try to see if I can suggest something that isn't quite as hacky</p>



<a name="160950477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/160950477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#160950477">(Mar 16 2019 at 12:51)</a>:</h4>
<p>I have a couple of PRs I'd like to get reviewed now that mw is unavailable. <a href="https://github.com/rust-lang/rust/pull/59064" target="_blank" title="https://github.com/rust-lang/rust/pull/59064">Turn HIR indexing into a query</a> (contains <a href="https://github.com/rust-lang/rust/pull/59091" target="_blank" title="https://github.com/rust-lang/rust/pull/59091">Combine input and eval_always query types</a>) and <a href="https://github.com/rust-lang/rust/pull/56462" target="_blank" title="https://github.com/rust-lang/rust/pull/56462">Define queries using a proc macro</a>.</p>



<a name="161143914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/161143914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#161143914">(Mar 19 2019 at 12:08)</a>:</h4>
<p>I've been told @mw isn't available for review rn. <span class="user-group-mention" data-user-group-id="1162">@WG-mir-opt</span> or others: Does someone want to review adding a new invocation of the branch simplification mir optimization? <a href="https://github.com/rust-lang/rust/pull/59290" target="_blank" title="https://github.com/rust-lang/rust/pull/59290">https://github.com/rust-lang/rust/pull/59290</a></p>



<a name="161144025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/161144025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#161144025">(Mar 19 2019 at 12:10)</a>:</h4>
<p>Looks good to me, can r=me (or I'll r+) once Travis finishes.</p>



<a name="161153200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/161153200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#161153200">(Mar 19 2019 at 14:08)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@davidtwco</span>  ;)</p>



<a name="161154067"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/161154067" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#161154067">(Mar 19 2019 at 14:18)</a>:</h4>
<p>saw the PR before this messages :)</p>



<a name="161154111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/161154111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#161154111">(Mar 19 2019 at 14:18)</a>:</h4>
<p>looked good to me too</p>



<a name="169357209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169357209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169357209">(Jun 30 2019 at 22:51)</a>:</h4>
<p>Does anybody want to review <a href="https://github.com/rust-lang/rust/pull/62042" target="_blank" title="https://github.com/rust-lang/rust/pull/62042">"Support stability and deprecation checking for all macros"</a>?<br>
It's series of refactorings/cleanups after which stability and deprecation mostly become implemented automatically.</p>



<a name="169659227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Simon Sapin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659227">(Jul 04 2019 at 16:27)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> In <a href="https://github.com/rust-lang/rust/pull/62330#discussion_r300064460" target="_blank" title="https://github.com/rust-lang/rust/pull/62330#discussion_r300064460">https://github.com/rust-lang/rust/pull/62330#discussion_r300064460</a>, are you asking for more tests? Doing what exactly? What this test does in the first place is not clear to me (even with the comment)</p>



<a name="169659309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659309">(Jul 04 2019 at 16:29)</a>:</h4>
<p><span class="user-mention" data-user-id="219747">@Simon Sapin</span> basically add:</p>
<div class="codehilite"><pre><span></span><span class="k">const</span><span class="w"> </span><span class="n">X</span>: <span class="p">()</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="p">(</span><span class="n">NoDrop</span><span class="w"> </span><span class="p">{</span><span class="w"> </span><span class="n">inner</span>: <span class="nc">ManuallyDrop</span>::<span class="n">new</span><span class="p">(</span><span class="n">NeedDrop</span><span class="p">)</span><span class="w"> </span><span class="p">},</span><span class="w"> </span><span class="p">()).</span><span class="mi">1</span><span class="p">;</span><span class="w"></span>

<span class="k">const</span><span class="w"> </span><span class="k">fn</span> <span class="nf">_f</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"> </span><span class="p">(</span><span class="n">NoDrop</span><span class="w"> </span><span class="p">{</span><span class="w"> </span><span class="n">inner</span>: <span class="nc">ManuallyDrop</span>::<span class="n">new</span><span class="p">(</span><span class="n">NeedDrop</span><span class="p">)</span><span class="w"> </span><span class="p">},</span><span class="w"> </span><span class="p">()).</span><span class="mi">1</span><span class="w"> </span><span class="p">}</span><span class="w"></span>
</pre></div>



<a name="169659379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659379">(Jul 04 2019 at 16:30)</a>:</h4>
<p>My understanding of this is that it is testing that since destructors are not run, it's fine inside a const context</p>



<a name="169659390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659390">(Jul 04 2019 at 16:30)</a>:</h4>
<p>and specifically how <code>ManuallyDrop</code> and friends achieve this</p>



<a name="169659408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Simon Sapin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659408">(Jul 04 2019 at 16:31)</a>:</h4>
<p>Ok</p>



<a name="169659422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/169659422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#169659422">(Jul 04 2019 at 16:31)</a>:</h4>
<p>Thanks; and ~good night-ish ;)  (very tired after 1.36.0 release, hehe)</p>



<a name="170616058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616058">(Jul 11 2019 at 09:18)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="119009">@eddyb</span> , do you want to review this change to print_def_path: <a href="https://github.com/rust-lang/rust/issues/62503" target="_blank" title="https://github.com/rust-lang/rust/issues/62503">#62503</a> ?</p>



<a name="170616086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616086">(Jul 11 2019 at 09:19)</a>:</h4>
<p>yeah it's on my catch-up list. I'll look at it now though</p>



<a name="170616094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616094">(Jul 11 2019 at 09:19)</a>:</h4>
<p>okay, its not urgent (as in, doesn't need to be done this minute).</p>



<a name="170616144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616144">(Jul 11 2019 at 09:20)</a>:</h4>
<p>I just figured since I'm going on leave after tomorrow, I should try to get my open PR's dealt with.</p>



<a name="170616231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616231">(Jul 11 2019 at 09:21)</a>:</h4>
<p>ughhhh cyclicity strikes again</p>



<a name="170616297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616297">(Jul 11 2019 at 09:22)</a>:</h4>
<p>by the way, I'm not clear on what the <code>bool</code> in the return value represents</p>



<a name="170616303"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616303" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616303">(Jul 11 2019 at 09:22)</a>:</h4>
<p>I'd be happy to add a comment explaining it if you want to enlighten me. :)</p>



<a name="170616319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616319">(Jul 11 2019 at 09:22)</a>:</h4>
<p>I thought there was a comment?</p>



<a name="170616333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616333">(Jul 11 2019 at 09:23)</a>:</h4>
<p>I didn't see one explaining the boolean</p>



<a name="170616341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616341">(Jul 11 2019 at 09:23)</a>:</h4>
<p>its possible I overlooked it</p>



<a name="170616345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616345">(Jul 11 2019 at 09:23)</a>:</h4>
<p>oh I forgot to update the comment. so, <code>Self</code> is always returned because of how that whole API works, and the <code>bool</code> is the actual result of the <code>try_...</code></p>



<a name="170616359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616359">(Jul 11 2019 at 09:23)</a>:</h4>
<p>the answer to the <code>If possible</code> in the doc comment</p>



<a name="170616418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616418">(Jul 11 2019 at 09:24)</a>:</h4>
<p>Oh okay</p>



<a name="170616424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616424">(Jul 11 2019 at 09:24)</a>:</h4>
<p>to be fair, it does say "and returns true"</p>



<a name="170616434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616434">(Jul 11 2019 at 09:24)</a>:</h4>
<p>oh, I see, the comment still talks about returning a path, but it should say "prints" instead of "returns"</p>



<a name="170616442"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616442" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616442">(Jul 11 2019 at 09:24)</a>:</h4>
<p>then the "and returns true" makes more sense</p>



<a name="170616447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170616447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170616447">(Jul 11 2019 at 09:25)</a>:</h4>
<p>yeah I should fix that too. <span aria-label="smile" class="emoji emoji-263a" role="img" title="smile">:smile:</span></p>



<a name="170617695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170617695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170617695">(Jul 11 2019 at 09:42)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> btw if you want to take a look at <a href="https://github.com/rust-lang/rust/issues/62584" target="_blank" title="https://github.com/rust-lang/rust/issues/62584">#62584</a> - took me a while to submit that fix, mostly because I wasn't sure how to properly explain the math at work here</p>



<a name="170617709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170617709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170617709">(Jul 11 2019 at 09:42)</a>:</h4>
<p>"rotating a range" sounds weird but it's pretty much what's happening</p>



<a name="170617798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170617798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170617798">(Jul 11 2019 at 09:44)</a>:</h4>
<p>Okay I'll see if I can get to it; I have some other stuff on my plate to take care of in the real world in the near term (we're moving offices and I still need to pack up my desk)</p>



<a name="170617964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170617964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170617964">(Jul 11 2019 at 09:46)</a>:</h4>
<p>don't worry about it then</p>



<a name="170621146"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170621146" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170621146">(Jul 11 2019 at 10:33)</a>:</h4>
<p>ah I'm reading it anyway</p>



<a name="170621147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170621147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170621147">(Jul 11 2019 at 10:33)</a>:</h4>
<p>who needs to pack</p>



<a name="170727824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727824">(Jul 12 2019 at 14:50)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> if you're still around, I'm curious if you're okay with this silly approach to having a lot of variants <a href="https://github.com/rust-lang/rust/pull/62584/files#diff-dac0b3d5a19b291538d6f171b7e8eb8bR16" target="_blank" title="https://github.com/rust-lang/rust/pull/62584/files#diff-dac0b3d5a19b291538d6f171b7e8eb8bR16">https://github.com/rust-lang/rust/pull/62584/files#diff-dac0b3d5a19b291538d6f171b7e8eb8bR16</a></p>



<a name="170727841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727841">(Jul 12 2019 at 14:50)</a>:</h4>
<p><span aria-label="scream" class="emoji emoji-1f631" role="img" title="scream">:scream:</span></p>



<a name="170727871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727871">(Jul 12 2019 at 14:51)</a>:</h4>
<p>not silly</p>



<a name="170727874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727874">(Jul 12 2019 at 14:51)</a>:</h4>
<p>looks great to me</p>



<a name="170727879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727879">(Jul 12 2019 at 14:51)</a>:</h4>
<p>(FWIW it does hit the second <code>unreachable!</code> as well on current Rust, so you were right to ask for this test)</p>



<a name="170727883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727883">(Jul 12 2019 at 14:51)</a>:</h4>
<p>(and the PR does fix it)</p>



<a name="170727970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727970">(Jul 12 2019 at 14:52)</a>:</h4>
<p>/me just finished packing. Took ... almost three hours</p>



<a name="170727986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727986">(Jul 12 2019 at 14:52)</a>:</h4>
<p>I was gonna do hundreds of lines but then I remembered hex packs nicely :P</p>



<a name="170727999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/170727999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#170727999">(Jul 12 2019 at 14:52)</a>:</h4>
<p>(I had a lot of physical garbage debt)</p>



<a name="171321354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/171321354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#171321354">(Jul 20 2019 at 10:11)</a>:</h4>
<p>I'd appreciate a review of <a href="https://github.com/rust-lang/rust/pull/59706" target="_blank" title="https://github.com/rust-lang/rust/pull/59706">https://github.com/rust-lang/rust/pull/59706</a> :)</p>



<a name="171323653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20requests/near/171323653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20requests.html#171323653">(Jul 20 2019 at 11:23)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span> Could you perhaps update the PR description? It still has some seemingly outdated language (draft PR, etc.)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>